Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backend support for user flair and donations leaderboard #2978

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Add backend support for user flair and donations leaderboard #2978

merged 4 commits into from
Sep 13, 2024

Conversation

amCap1712
Copy link
Member

No description provided.

@pep8speaks
Copy link

pep8speaks commented Sep 11, 2024 •
edited
Loading

Hello @amCap1712! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 42:62: W291 trailing whitespace
Line 125:35: W291 trailing whitespace
Line 147:23: W291 trailing whitespace

Comment last updated at 2024-09-13 20:10:02 UTC

mayhem
mayhem requested changes Sep 11, 2024
View reviewed changes
Copy link
Member

@mayhem mayhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more comments needed and a change to see if a user has recently donated.

listenbrainz/config.py.sample Show resolved Hide resolved
listenbrainz/db/donation.py Show resolved Hide resolved
listenbrainz/db/donation.py Outdated Show resolved Hide resolved
listenbrainz/db/donation.py Outdated Show resolved Hide resolved
@amCap1712 amCap1712 merged commit 737c369 into master Sep 13, 2024
2 checks passed
@amCap1712 amCap1712 deleted the donation branch September 13, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayhem mayhem Awaiting requested review from mayhem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amCap1712 @pep8speaks @mayhem