Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RG Secondary Types in cache #2977

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Add RG Secondary Types in cache #2977

merged 2 commits into from
Sep 10, 2024

Conversation

anshg1214
Copy link
Member

This PR adds Secondary Types of Release Group in the mb_artist_metadata_cache.

@pep8speaks
Copy link

pep8speaks commented Sep 9, 2024 •
edited
Loading

Hello @anshg1214! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 83:131: E501 line too long (178 > 130 characters)

Comment last updated at 2024-09-09 13:18:57 UTC

amCap1712
amCap1712 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@amCap1712 amCap1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@anshg1214 anshg1214 merged commit 37f9739 into master Sep 10, 2024
2 checks passed
@anshg1214 anshg1214 deleted the ansh/add-secondary-types branch September 10, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amCap1712 amCap1712 amCap1712 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anshg1214 @pep8speaks @amCap1712