-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Apple Music playback into ListenBrainz #2509
Commits on Jun 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ed43342 - Browse repository at this point
Copy the full SHA ed43342View commit details
Commits on Jul 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d7e302d - Browse repository at this point
Copy the full SHA d7e302dView commit details
Commits on Jul 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3a6dc07 - Browse repository at this point
Copy the full SHA 3a6dc07View commit details -
code review changes are addressed
Removed some console messages Uncommented spotify, youtube and soundcloud made some type changes removed some extra types from musickit.d.ts
Configuration menu - View commit details
-
Copy full SHA for 1baa9af - Browse repository at this point
Copy the full SHA 1baa9afView commit details -
I removed some code in last commit but it did not stop preview so adding it again.
Configuration menu - View commit details
-
Copy full SHA for 0cdca81 - Browse repository at this point
Copy the full SHA 0cdca81View commit details
Commits on Jul 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9cda13f - Browse repository at this point
Copy the full SHA 9cda13fView commit details
Commits on Jul 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1bbd86c - Browse repository at this point
Copy the full SHA 1bbd86cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 74613ff - Browse repository at this point
Copy the full SHA 74613ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9562ce3 - Browse repository at this point
Copy the full SHA 9562ce3View commit details
Commits on Jul 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f87a8b0 - Browse repository at this point
Copy the full SHA f87a8b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75ddd7b - Browse repository at this point
Copy the full SHA 75ddd7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a4450c - Browse repository at this point
Copy the full SHA 7a4450cView commit details
Commits on Jul 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1771df6 - Browse repository at this point
Copy the full SHA 1771df6View commit details
Commits on Jul 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b419201 - Browse repository at this point
Copy the full SHA b419201View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ea74cf - Browse repository at this point
Copy the full SHA 1ea74cfView commit details
Commits on Aug 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ee0de32 - Browse repository at this point
Copy the full SHA ee0de32View commit details -
Configuration menu - View commit details
-
Copy full SHA for f63ba13 - Browse repository at this point
Copy the full SHA f63ba13View commit details
Commits on Mar 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 245337d - Browse repository at this point
Copy the full SHA 245337dView commit details -
Re-add AppleMusic service button
The HTML page we previously had was refactored and now in JS comnponent instead
Configuration menu - View commit details
-
Copy full SHA for fcdebb1 - Browse repository at this point
Copy the full SHA fcdebb1View commit details -
Refactor Apple Music oauth mechanism
Let's try not to special-case the service with custom endpoints if we can avoid it. I have no way to test this properly so it will need another pass to finish and test the implementation
Configuration menu - View commit details
-
Copy full SHA for fc69c80 - Browse repository at this point
Copy the full SHA fc69c80View commit details -
Configuration menu - View commit details
-
Copy full SHA for e442d19 - Browse repository at this point
Copy the full SHA e442d19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b96fc9 - Browse repository at this point
Copy the full SHA 1b96fc9View commit details
Commits on Mar 26, 2024
-
Reimplement custom AppleMusic auth methods
Apple uses a non-standard oauth workflow with no refresh tokens, and requiring the use of their MusicKit library to authenticate, which means we need to send the token from the front-end to the back-end
Configuration menu - View commit details
-
Copy full SHA for 4cf7b07 - Browse repository at this point
Copy the full SHA 4cf7b07View commit details -
Reimplement authentication in AppleMusicPlayer
Export some reusable methods to load the musickitJS library, instantiate an instance, and authorize the current user. Reusable so we can use them on the music-services settings page
Configuration menu - View commit details
-
Copy full SHA for 09945ea - Browse repository at this point
Copy the full SHA 09945eaView commit details -
Reimplement apple music account linking
in the settings/music-services page, requiring a custom method since apple uses a non-standard auth workflow (see previous commits)
Configuration menu - View commit details
-
Copy full SHA for 7f8b3de - Browse repository at this point
Copy the full SHA 7f8b3deView commit details -
Configuration menu - View commit details
-
Copy full SHA for d488bc8 - Browse repository at this point
Copy the full SHA d488bc8View commit details
Commits on Mar 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for be0f9f3 - Browse repository at this point
Copy the full SHA be0f9f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5f5199 - Browse repository at this point
Copy the full SHA a5f5199View commit details
Commits on Mar 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7eddfb3 - Browse repository at this point
Copy the full SHA 7eddfb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1abbb1d - Browse repository at this point
Copy the full SHA 1abbb1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f886cce - Browse repository at this point
Copy the full SHA f886cceView commit details -
Remove cryptography dependency
Note sure why this was added, but it's making the entire test suite fail.
Configuration menu - View commit details
-
Copy full SHA for 70387e7 - Browse repository at this point
Copy the full SHA 70387e7View commit details
Commits on Apr 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 376c337 - Browse repository at this point
Copy the full SHA 376c337View commit details
Commits on Apr 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bd5cf32 - Browse repository at this point
Copy the full SHA bd5cf32View commit details
Commits on Apr 12, 2024
-
Add AppleMusic to BrainzPlayer settings page
Allows enabling/disabling the apple music player
Configuration menu - View commit details
-
Copy full SHA for 464f47f - Browse repository at this point
Copy the full SHA 464f47fView commit details -
Fix current permissions for Apple Music
On the music services page, it was showing apple music as connected at all times regardless of the connection status, because it was using the wrong value to determine the connection status
Configuration menu - View commit details
-
Copy full SHA for 94b24b5 - Browse repository at this point
Copy the full SHA 94b24b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fd3836 - Browse repository at this point
Copy the full SHA 8fd3836View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fc4261 - Browse repository at this point
Copy the full SHA 0fc4261View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f7a51c - Browse repository at this point
Copy the full SHA 0f7a51cView commit details -
Configuration menu - View commit details
-
Copy full SHA for afb944d - Browse repository at this point
Copy the full SHA afb944dView commit details
Commits on Apr 15, 2024
-
Apply suggestions from code review
Co-authored-by: Ansh Goyal <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f703002 - Browse repository at this point
Copy the full SHA f703002View commit details -
Remove unused APPLE_MUSIC_REDIRECT_URI env variable
The Apple Music authorization is not an OAuth flow, and we don't use that variable anywhere in the codebase
Configuration menu - View commit details
-
Copy full SHA for 8a942d2 - Browse repository at this point
Copy the full SHA 8a942d2View commit details
Commits on Apr 17, 2024
-
Remove bitrate configuration option
SOMEHOW adding this perfectly valid bitrate configuration option completely break the MusicKit player in our application, and I have no idea why. Tried in a minimal repro and the option is valid and does not break anything. Don't ask me why, I already lost a day on this trying to figure out why music wasn't playing anymore even though it was working previously.
Configuration menu - View commit details
-
Copy full SHA for 6f7f013 - Browse repository at this point
Copy the full SHA 6f7f013View commit details -
Otherwise, currently it just skips to the next one automatically
Configuration menu - View commit details
-
Copy full SHA for 0e71ed8 - Browse repository at this point
Copy the full SHA 0e71ed8View commit details
Commits on Apr 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 17fe18d - Browse repository at this point
Copy the full SHA 17fe18dView commit details