Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Apple Music playback into ListenBrainz #2509

Merged
merged 45 commits into from
Apr 18, 2024

Commits on Jun 26, 2023

  1. Configuration menu
    Copy the full SHA
    ed43342 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2023

  1. Configuration menu
    Copy the full SHA
    d7e302d View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Configuration menu
    Copy the full SHA
    3a6dc07 View commit details
    Browse the repository at this point in the history
  2. code review changes are addressed

    Removed some console messages
    Uncommented spotify, youtube and soundcloud
    made some type changes
    removed some extra types from musickit.d.ts
    vardansaini committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    1baa9af View commit details
    Browse the repository at this point in the history
  3. stopping preview again

    I removed some code in last commit but it did not stop preview so adding it again.
    vardansaini committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    0cdca81 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. Configuration menu
    Copy the full SHA
    9cda13f View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Configuration menu
    Copy the full SHA
    1bbd86c View commit details
    Browse the repository at this point in the history
  2. merging master

    vardansaini committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    74613ff View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9562ce3 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Configuration menu
    Copy the full SHA
    f87a8b0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    75ddd7b View commit details
    Browse the repository at this point in the history
  3. minor fix

    vardansaini committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    7a4450c View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Configuration menu
    Copy the full SHA
    1771df6 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Configuration menu
    Copy the full SHA
    b419201 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1ea74cf View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Configuration menu
    Copy the full SHA
    ee0de32 View commit details
    Browse the repository at this point in the history
  2. Fix snapshot

    amCap1712 committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    f63ba13 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Configuration menu
    Copy the full SHA
    245337d View commit details
    Browse the repository at this point in the history
  2. Re-add AppleMusic service button

    The HTML page we previously had was refactored and now in JS comnponent instead
    MonkeyDo committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    fcdebb1 View commit details
    Browse the repository at this point in the history
  3. Refactor Apple Music oauth mechanism

    Let's try not to special-case the service  with custom endpoints if we can avoid it.
    I have no way to test this properly so it will need another pass to finish and test the implementation
    MonkeyDo committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    fc69c80 View commit details
    Browse the repository at this point in the history
  4. Fix extraneous prop

    + random character I saved by mistake
    MonkeyDo committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    e442d19 View commit details
    Browse the repository at this point in the history
  5. Remove old dependency

    MonkeyDo committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    1b96fc9 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Reimplement custom AppleMusic auth methods

    Apple uses a non-standard oauth workflow with no refresh tokens, and requiring the use of their MusicKit library to authenticate, which means we need to send the token from the front-end to the back-end
    MonkeyDo committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    4cf7b07 View commit details
    Browse the repository at this point in the history
  2. Reimplement authentication in AppleMusicPlayer

    Export some reusable methods to load the musickitJS library, instantiate an instance, and authorize the current user.
    Reusable so we can use them on the music-services settings page
    MonkeyDo committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    09945ea View commit details
    Browse the repository at this point in the history
  3. Reimplement apple music account linking

    in the settings/music-services page, requiring a custom method since apple uses a non-standard auth workflow (see previous commits)
    MonkeyDo committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    7f8b3de View commit details
    Browse the repository at this point in the history
  4. Catch some error cases

    +small formatting issues
    MonkeyDo committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    d488bc8 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Configuration menu
    Copy the full SHA
    be0f9f3 View commit details
    Browse the repository at this point in the history
  2. Fix code issues

    MonkeyDo committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    a5f5199 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Configuration menu
    Copy the full SHA
    7eddfb3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1abbb1d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f886cce View commit details
    Browse the repository at this point in the history
  4. Remove cryptography dependency

    Note sure why this was added, but it's making the entire test suite fail.
    MonkeyDo authored Mar 28, 2024
    Configuration menu
    Copy the full SHA
    70387e7 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. Configuration menu
    Copy the full SHA
    376c337 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Configuration menu
    Copy the full SHA
    bd5cf32 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Add AppleMusic to BrainzPlayer settings page

    Allows enabling/disabling the apple music player
    MonkeyDo committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    464f47f View commit details
    Browse the repository at this point in the history
  2. Fix current permissions for Apple Music

    On the music services page, it was showing  apple music as connected at all times regardless of the connection status, because it was using the wrong value to determine the connection status
    MonkeyDo committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    94b24b5 View commit details
    Browse the repository at this point in the history
  3. Typo

    Mais que diable ?1
    MonkeyDo committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    8fd3836 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0fc4261 View commit details
    Browse the repository at this point in the history
  5. Pep8 le pew

    MonkeyDo committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    0f7a51c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    afb944d View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Apply suggestions from code review

    Co-authored-by: Ansh Goyal <[email protected]>
    MonkeyDo and anshg1214 authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    f703002 View commit details
    Browse the repository at this point in the history
  2. Remove unused APPLE_MUSIC_REDIRECT_URI env variable

    The Apple Music authorization is not an OAuth flow, and we don't use that variable anywhere in the codebase
    MonkeyDo committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    8a942d2 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Remove bitrate configuration option

    SOMEHOW adding this perfectly valid bitrate configuration option completely break the MusicKit player in our application, and I have no idea why.
    Tried in a minimal repro and the option is valid and does not break anything.
    Don't ask me why, I already lost a day on this trying to figure out why music wasn't playing anymore even though it was working previously.
    MonkeyDo committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    6f7f013 View commit details
    Browse the repository at this point in the history
  2. Return after finding track

    Otherwise, currently it just skips to the next one automatically
    MonkeyDo committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    0e71ed8 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Configuration menu
    Copy the full SHA
    17fe18d View commit details
    Browse the repository at this point in the history