Moved card Link logic to viewModel #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
07jasjeet
requested changes
Jan 11, 2025
| import org.listenbrainz.android.util.Constants.MB_BASE_URL | ||
|
|
||
| object LinkUtils { | ||
| fun fetchLinks(artistMbid: String?, links: Rels?): Map<ArtistLinksEnum, List<LinkCardData>> { |
There was a problem hiding this comment.
Since this is not an remote API call of sorts, can we name this parseLinks or anything you feel right. Its easier to recall this function this way when its time to reuse it.
|
@07jasjeet I have made the required changes. Thanks for the review! |
|
@hemang-mishra, thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I completed the TODO mentioned in the Artist Screen to move
linksMaplogic toviewModel.//TODO: Move this logic to vm and get map to ui stateThe changes made are:
utilpackage.linksMapin UiState to get the links.ImageVector.vectorResourcecan be called only in compose function, so I have modifedLinksCarddata class to contain resource id instead of ImageVector.