chore: Allow annotation revision ids to be null (rebased) #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of #1105
Also see metabrainz/bookbrainz-data-js#320
For imported entities, we do not keep a history of all modifications.
As a result, editing import_* entities is not tied to any revisions.
This is an issue for annotations, whose
last_revision_idcolumn does not currently accept NULL values.These small changes allow entering a row in the
annotationtable withlast_revision_id = NULL, and ensure the website does not trip up if the value is missing (it is used to display the last modification time and link to the revision)Before:
After:
