Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix BB-782 : Unable to edit Author Credit after having set it #1092

Merged
merged 2 commits into from
May 30, 2024

Conversation

Tarunmeena0901
Copy link
Contributor

Problem

BB-782

Solution

problem : #1071 (comment)

WARNING⚠️ : HUGE NUMBER OF CHANGES IN LINES OF CODE

Areas of Impact

author credit section

@Tarunmeena0901
Copy link
Contributor Author

Sorry for keeping this issue waiting for some extra days. It was just a 10-second fix.

Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it took me 6 hours to review allll these lines of code, so please keep this in mind next time and break your PR up in, say, one PR per changed character 🤣

In all seriousness, thanks a lot for finding and fixing this. A simple change, yet an annoying bug fixed!

@MonkeyDo MonkeyDo merged commit 18178d4 into metabrainz:master May 30, 2024
4 checks passed
@Tarunmeena0901
Copy link
Contributor Author

thanks for the review 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants