Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BB-722: Display already selected achievements in Edit Achievement Page #1033

Merged
merged 4 commits into from
Jan 18, 2024
Merged

BB-722: Display already selected achievements in Edit Achievement Page #1033

merged 4 commits into from
Jan 18, 2024

Conversation

anshg1214
Copy link
Member

BB-722: Display already selected achievements in Edit Achievement Page

@anshg1214 anshg1214 requested a review from MonkeyDo November 1, 2023 14:02
MonkeyDo
MonkeyDo reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's been bugging me :)

Some style comments below

src/client/components/input/drag-and-drop.tsx Show resolved Hide resolved
src/client/components/input/drag-and-drop.tsx Show resolved Hide resolved
src/client/components/input/drag-and-drop.tsx Show resolved Hide resolved
src/server/routes/editor.tsx Outdated Show resolved Hide resolved
@MonkeyDo MonkeyDo mentioned this pull request Nov 9, 2023
Merged
MonkeyDo
MonkeyDo approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more change plz :)

src/server/routes/editor.tsx Show resolved Hide resolved
@MonkeyDo MonkeyDo self-requested a review January 12, 2024 16:06
MonkeyDo
MonkeyDo requested changes Jan 12, 2024
View reviewed changes
Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops.

@MonkeyDo
Copy link
Member

Thank you ! 🚀

@MonkeyDo MonkeyDo merged commit e2cb1e0 into metabrainz:master Jan 18, 2024
4 checks passed
@anshg1214 anshg1214 deleted the BB-722 branch January 18, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonkeyDo MonkeyDo MonkeyDo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshg1214 @MonkeyDo