Merge pull request #1048 from insane-22/empty-identifiers-prevent-sub…

…mission BB-766:Empty identifiers/aliases prevent submission of an entity
metabrainz · Feb 21, 2024 · 1bf5aee · 1bf5aee
2 parents c4f1c44 + 70d3644
commit 1bf5aee
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/client/entity-editor/alias-editor/reducer.js b/src/client/entity-editor/alias-editor/reducer.js
@@ -50,7 +50,7 @@ function reducer(
 			return state.delete(payload);
 		case REMOVE_EMPTY_ALIASES:
 			return state.filterNot(alias =>
-				alias.get('name') === '' && alias.get('language') === null && alias.get('sortName') === '');
+				alias.get('name') === '');
 		// no default
 	}
 	return state;

diff --git a/src/client/entity-editor/identifier-editor/reducer.ts b/src/client/entity-editor/identifier-editor/reducer.ts
@@ -58,7 +58,7 @@ function reducer(
 			return state.delete(payload);
 		case REMOVE_EMPTY_IDENTIFIERS:
 			return state.filterNot(identifier =>
-				identifier.get('value') === '' && identifier.get('type') === null);
+				identifier.get('value') === '');
 		case ADD_OTHER_ISBN: {
 			const {rowId, value, type: typeId} = payload;
 			// search if given identifier already exists