Lint pull requests

fix BB-343 : Integrated the modification of identifiers and aliases into the primary editing workflow #1027

Sign in to view logs

Triggered via pull request April 23, 2024 22:39

synchronize #1043

Status Success

Total duration 1m 9s

Artifacts –

lint-pull-requests.yml

on: pull_request_target

Run linters for pull requests

Annotations

11 errors and 5 warnings

test/src/server/routes/entity/author.js ► Author routes with entity editing priv ► should not throw an error if creating new author: test-results.json#L0

Failed test found in: test-results.json Error: Timeout of 50000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/bookbrainz-site/bookbrainz-site/test/src/server/routes/entity/author.js)

test/src/server/routes/entity/author.js ► Author routes with entity editing priv ► should not throw an error trying to edit an existing author: test/src/server/routes/entity/author.js#L47

Failed test found in: test-results.json Error: expected false to be true

test/src/server/routes/entity/author.js ► Author routes with entity editing priv ► should not throw error while seeding author: test-results.json#L0

Failed test found in: test-results.json Error: Timeout of 50000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/bookbrainz-site/bookbrainz-site/test/src/server/routes/entity/author.js)

test/src/server/routes/entity/edition-group.js ► Edition Group routes with entity editing priv ► should not throw an error if creating new edition-group: test-results.json#L0

Failed test found in: test-results.json Error: Timeout of 50000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/bookbrainz-site/bookbrainz-site/test/src/server/routes/entity/edition-group.js)

test/src/server/routes/entity/edition-group.js ► Edition Group routes with entity editing priv ► should not throw an error trying to edit an existing edition group: test/src/server/routes/entity/edition-group.js#L47

Failed test found in: test-results.json Error: expected false to be true

test/src/server/routes/entity/edition-group.js ► Edition Group routes with entity editing priv ► should not throw error while seeding edition group: test-results.json#L0

Failed test found in: test-results.json Error: Timeout of 50000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/bookbrainz-site/bookbrainz-site/test/src/server/routes/entity/edition-group.js)

test/src/server/routes/entity/edition.js ► Edition routes with entity editing priv ► should not throw an error if creating new edition: test/src/server/routes/entity/edition.js#L40

Failed test found in: test-results.json Error: expected false to be true

test/src/server/routes/entity/edition.js ► Edition routes with entity editing priv ► should not throw an error trying to edit an existing edition: test/src/server/routes/entity/edition.js#L46

Failed test found in: test-results.json Error: expected false to be true

test/src/server/routes/entity/edition.js ► Edition routes with entity editing priv ► should not throw error while seeding edition: test/src/server/routes/entity/edition.js#L63

Failed test found in: test-results.json Error: expected false to be true

test/src/server/routes/entity/publisher.js ► Publisher routes with entity editing priv ► should not throw an error if creating new publisher: test-results.json#L0

Failed test found in: test-results.json Error: Timeout of 50000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/bookbrainz-site/bookbrainz-site/test/src/server/routes/entity/publisher.js)

test/src/server/routes/entity/publisher.js ► Publisher routes with entity editing priv ► should not throw an error trying to edit an existing publisher: test/src/server/routes/entity/publisher.js#L47

Failed test found in: test-results.json Error: expected false to be true

src/client/components/pages/revision.js#L177

Unexpected 'todo' comment: 'TODO: Add proper error handling.' (no-warning-comments)

src/server/helpers/collectionRouteUtils.js#L22

'log' is defined but never used (@typescript-eslint/no-unused-vars)

src/server/routes/register.js#L22

'handler' is defined but never used (@typescript-eslint/no-unused-vars)

Run linters for pull requests

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, wearerequired/lint-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Run linters for pull requests

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, wearerequired/lint-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/