Skip to content

refactor(profile): refactor achievement to typescript #892

refactor(profile): refactor achievement to typescript

refactor(profile): refactor achievement to typescript #892

Triggered via pull request October 5, 2023 11:34
@meziyummeziyum
synchronize #1025
Status Success
Total duration 1m 1s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

lint-pull-requests.yml

on: pull_request_target
Run linters for pull requests
49s
Run linters for pull requests
Fit to window
Zoom out
Zoom in

Annotations

1 error and 8 warnings
test/src/api/routes/test-publisher.js ► Browse Publishers ► should return publishers associated with an edition: test-results.json#L0
Failed test found in: test-results.json Error: insert into "bookbrainz"."publisher_type" ("label") values ($1) returning * - duplicate key value violates unique constraint "publisher_type_label_key"
src/client/components/pages/revision.js#L108
This line has a length of 166. Maximum allowed is 150 (max-len)
src/client/components/pages/revision.js#L112
This line has a length of 163. Maximum allowed is 150 (max-len)
src/client/components/pages/revision.js#L119
This line has a length of 154. Maximum allowed is 150 (max-len)
src/client/components/pages/revision.js#L164
Unexpected 'todo' comment: 'TODO: Add proper error handling.' (no-warning-comments)
src/server/routes/editor.js#L561
Unexpected 'todo' comment: 'TODO: this can throw, so missing error...' (no-warning-comments)
src/server/routes/search.js#L59
'total' is assigned a value but never used (@typescript-eslint/no-unused-vars)
src/server/routes/search.js#L148
Unexpected 'todo' comment: 'TODO: This is hacky, and we should...' (no-warning-comments)
Run linters for pull requests
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, wearerequired/lint-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/