add label derive macro #3
Conversation
| @@ -42,14 +42,14 @@ jobs: | |||
| command: fmt | |||
| args: --all -- --check | |||
| test: | |||
| name: Test Stable | |||
| name: Test Beta | |||
There was a problem hiding this comment.
I assume this is done temporarily, to use the new impl-stuff?
There was a problem hiding this comment.
indeed, in 6 weeks this can be put back!
| scopegraphs-lib = {path="../scopegraphs-lib"} | ||
| scopegraphs-macros = {path="../scopegraphs-macros"} |
There was a problem hiding this comment.
How will this work when we (eventually) publish the crate. Will the reexport take care that everything in these libraries is available?
There was a problem hiding this comment.
indeed, scopegraphs is like a facade library, it simply reexports all these lower level libs, but it is what users will import. Later we aren't just going to use paths, but also version these, but there are tools for that. Terts has a lot of experience with this from uutils, I hope he knows what works best here :)
There was a problem hiding this comment.
Yeah cargo-release or something like that will probably work well. (In uutils we do all of this with a super ugly bash script 😄)
There was a problem hiding this comment.
Doing it like this also makes compilation efficient. scopegraphs-macros can now compile entirely independently from scopegraphs-lib, in parallel.
|
The doctest arealso failing on the target branch, and is probably a bigger problem we have to solve later once there is some kind of actual implementation of the type. |
No description provided.