Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove default endDates #148

Closed
wants to merge 1 commit into from
Closed

remove default endDates #148

wants to merge 1 commit into from

Conversation

swaggymarie
Copy link
Contributor

New slot system indicated endSlot can't be set to null, but endDate would be if the proposal is not endend. So we don't want any default endDate

@swaggymarie swaggymarie marked this pull request as ready for review June 7, 2024 12:44
@R-K-H
Copy link
Member

R-K-H commented Jun 7, 2024

Wait, then how do we know when it's supposed to end? I thought the endDate is now automatically calculated via the indexer and we can load that or the default date?

@swaggymarie
Copy link
Contributor Author

No I told you, we're handling that on the frontend so we can have a easy "watch slot" that updates in real time the ending date and remaining slot

  • it allows to not watch for change on the overall proposal but just slot, giving more responsiveness
  • it also aligns with the way completedAt date works, so if it's not finished, there is simply no endedAt date

the indexer only adds an end date when current slot > end slot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants