fix await Promise all #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R-K-H
reviewed
May 28, 2024
| signedSequence.map((set) => | ||
| Promise.all( | ||
| await Promise.all(signedSequence.map(async (set) => | ||
| await Promise.all( |
There was a problem hiding this comment.
Ideally we're sending the txn signature back while we wait, but don't know outside of metaDAOproject/meta-dao-frontend#63 and https://github.com/metaDAOproject/meta-dao-frontend/pull/75/files as options to do so. This is an improvement for sure and we're likely going to merge it (once I see it in action shortly).
Just wanted to draw attention to a possible solution.
kilgaloon
pushed a commit
that referenced
this pull request
Aug 6, 2024
* fix await Promise all * add transaction response type * version bump --------- Co-authored-by: Kollan House <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.