feat: param rename for maxBaseAmount

metaDAOproject · May 2, 2024 · c085ece · c085ece
1 parent ee31bf0
commit c085ece
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 10 deletions.
diff --git a/lib/client/client.ts b/lib/client/client.ts
@@ -101,11 +101,11 @@ export interface FutarchyAmmMarketsClient {
   validateAddLiquidity(
     ammMarket: AmmMarket,
     quoteAmount: number,
-    baseAmount: number
+    maxBaseAmount: number
   ): LiquidityAddError | null;
   addLiquidity(
     ammAddr: AmmMarket,
     quoteAmount: number,
-    baseAmount: number
+    maxBaseAmount: number
   ): Promise<string[] | LiquidityAddError>;
 }
diff --git a/lib/client/indexer/market-clients/ammMarkets.ts b/lib/client/indexer/market-clients/ammMarkets.ts
@@ -30,24 +30,24 @@ export class FutarchyIndexerAmmMarketsClient
   validateAddLiquidity(
     ammMarket: AmmMarket,
     quoteAmount: number,
-    baseAmount: number
+    maxBaseAmount: number
   ): LiquidityAddError | null {
     return this.rpcMarketsClient.validateAddLiquidity(
       ammMarket,
       quoteAmount,
-      baseAmount
+      maxBaseAmount
     );
   }
 
   async addLiquidity(
     ammMarket: AmmMarket,
     quoteAmount: number,
-    baseAmount: number
+    maxBaseAmount: number
   ): Promise<string[] | LiquidityAddError> {
     return this.rpcMarketsClient.addLiquidity(
       ammMarket,
       quoteAmount,
-      baseAmount
+      maxBaseAmount
     );
   }
 

diff --git a/lib/client/rpc/market-clients/ammMarkets.ts b/lib/client/rpc/market-clients/ammMarkets.ts
@@ -126,11 +126,12 @@ export class FutarchyAmmMarketsRPCClient implements FutarchyAmmMarketsClient {
     );
 
     // we just pass this in as min LP tokens and this replicates the calculation in the program
-    const lpTokensToMint = quoteAmountArg
+    // TODO multiple this times slippage
+    const minLpTokensToMint = quoteAmountArg
       .mul(new BN(ammMarket.lpMintSupply))
       .div(ammMarket.quoteAmount);
 
-    const baseAmountArg = new BN(
+    const maxBaseAmountArg = new BN(
       maxBaseAmount *
         new BN(10).pow(new BN(ammMarket.baseToken.decimals)).toNumber()
     );
@@ -140,8 +141,8 @@ export class FutarchyAmmMarketsRPCClient implements FutarchyAmmMarketsClient {
       ammMarket.baseMint,
       ammMarket.quoteMint,
       quoteAmountArg,
-      baseAmountArg,
-      lpTokensToMint,
+      maxBaseAmountArg,
+      minLpTokensToMint,
       this.rpcProvider.publicKey
     );
     const tx = await ix.transaction();