Merge pull request #235 from metaDAOproject/fix/converting-twice

fix: do not need to convert many times
metaDAOproject · Aug 17, 2024 · cf71eef · cf71eef
2 parents d015124 + 9d19d43
commit cf71eef
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/packages/indexer/src/indexers/autocrat/autocrat-proposal-indexer.ts b/packages/indexer/src/indexers/autocrat/autocrat-proposal-indexer.ts
@@ -705,7 +705,7 @@ async function calculateUserPerformance(
     }
 
     const baseTokenDecimals = base_tokens?.decimals ?? -1;
-    const quoteTokenDecimals = quote_tokens?.decimals ?? -1;
+    const quoteTokenDecimals = quote_tokens?.decimals ?? 6; // NOTE: Safe for now
     if (!baseTokenDecimals && !quoteTokenDecimals) {
       return current;
     }
@@ -717,16 +717,13 @@ async function calculateUserPerformance(
     );
 
     // Amount or notional
-    const amount = PriceMath.getChainAmount(
-      Number(next.quotePrice).valueOf() * size,
-      quoteTokenDecimals // By default this should be 6
-    );
+    const amount = Number(next.quotePrice).valueOf() * size
 
     if (next.side === "BID") {
-      totals.tokensBought = totals.tokensBought + (Number(next.filledBaseAmount) / 10 ** baseTokenDecimals);
+      totals.tokensBought = totals.tokensBought + size;
       totals.volumeBought = totals.volumeBought + amount;
     } else if (next.side === "ASK") {
-      totals.tokensSold = totals.tokensSold + (Number(next.filledBaseAmount) / 10 ** baseTokenDecimals);
+      totals.tokensSold = totals.tokensSold + size;
       totals.volumeSold = totals.volumeSold + amount;
     }