Add llama download support for multiple models with comma-separated list
#243
+46
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABucket
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn and
raghotham
as code owners
facebook-github-bot
added
the
CLA Signed
yanxi0830
requested changes
Oct 15, 2024
ashwinb
requested changes
Oct 15, 2024
| elif args.model_id: | ||
| model_ids = [args.model_id] | ||
| else: | ||
| parser.error("Please provide a model id or a list of model ids (--model-ids)") |
There was a problem hiding this comment.
nit: Please provide a model using --model-id or --model-ids
| @@ -48,6 +48,11 @@ def setup_download_parser(parser: argparse.ArgumentParser) -> None: | |||
| required=False, | |||
| help="See `llama model list` or `llama model list --show-all` for the list of available models", | |||
There was a problem hiding this comment.
can we just make this nargs='+' so you can provide it multiple times like --model-id A --model-id B?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #233 , allowing users to pass a comma-separated list of model IDs with the --model-ids argument and matching meta URLs via --meta-url.