-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[functionality] Implement completion() methods #168 #173
base: main
Are you sure you want to change the base?
Conversation
C0deXG
commented
Oct 2, 2024
- Implemented completion() method for meta-reference, fireworks, together, ollama, and bedrock providers
- Each implementation handles both streaming and non-streaming responses
- Converted single content to messages when necessary
- Ensured proper yield of CompletionResponse or CompletionResponseStreamChunk objects
- Implemented completion() method for meta-reference, fireworks, together, ollama, and bedrock providers - Each implementation handles both streaming and non-streaming responses - Converted single content to messages when necessary - Ensured proper yield of CompletionResponse or CompletionResponseStreamChunk objects
Hi @C0deXG! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
completion_message=message, | ||
logprobs=logprobs if request.logprobs else None, | ||
) | ||
buffer = buffer[len(" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uh oh, this looks like an unintentional deletion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uh oh, this looks like an unintentional deletion?
in my machine is not cut off i dont know why
Can you also run
then -- whenever you run any git commit, it will run the linting hooks. |
yes |
Hey @C0deXG are you still interested and have the bandwidth to follow up on this PR? |