Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix event logger for ContentDelta update #83

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

yanxi0830
Copy link
Contributor

What does this PR do?

Issue

image

Test Plan

image

Sources

Please link relevant resources if necessary.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Ran pre-commit to handle lint / formatting issues.
  • Read the contributor guideline,
    Pull Request section?
  • Updated relevant documentation.
  • Wrote necessary unit or integration tests.

Sorry, something went wrong.

@yanxi0830 yanxi0830 marked this pull request as ready for review January 15, 2025 01:48
@yanxi0830 yanxi0830 merged commit eff4661 into main Jan 15, 2025
2 checks passed
@yanxi0830 yanxi0830 deleted the content-delta-event-logger branch January 15, 2025 17:58
@@ -28,6 +28,6 @@ def log(self, event_generator):
if event.event_type == "start":
yield LogEvent("Assistant> ", color="cyan", end="")
elif event.event_type == "progress":
yield LogEvent(event.delta, color="yellow", end="")
yield LogEvent(event.delta.text, color="yellow", end="")
Copy link
Contributor

@ashwinb ashwinb Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanxi0830 this is not correct. you should check the type of the delta and then if it is a text delta print this or if there is a tool call in there, print that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants