Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support system mesage behavior #119

Closed
wants to merge 1 commit into from
Closed

support system mesage behavior #119

wants to merge 1 commit into from

Conversation

ehhuang
Copy link
Contributor

@ehhuang ehhuang commented Feb 3, 2025 •
edited
Loading

What does this PR do?

Updates AgentConfig to support meta-llama/llama-stack#938

  • Addresses issue (#issue)

Test Plan

Tested in meta-llama/llama-stack#938

Sources

Please link relevant resources if necessary.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Ran pre-commit to handle lint / formatting issues.
  • Read the contributor guideline,
    Pull Request section?
  • Updated relevant documentation.
  • Wrote necessary unit or integration tests.

@ehhuang
support system mesage behavior
6c538fe 
# What does this PR do?

Updates AgentConfig to support meta-llama/llama-stack#938

- [ ] Addresses issue (#issue)


## Test Plan

Tested in meta-llama/llama-stack#938

## Sources

Please link relevant resources if necessary.


## Before submitting

- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [ ] Ran pre-commit to handle lint / formatting issues.
- [ ] Read the [contributor guideline](https://github.com/meta-llama/llama-stack/blob/main/CONTRIBUTING.md),
      Pull Request section?
- [ ] Updated relevant documentation.
- [ ] Wrote necessary unit or integration tests.
@ehhuang ehhuang marked this pull request as ready for review February 3, 2025 20:37
yanxi0830
yanxi0830 requested changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@yanxi0830 yanxi0830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synced offline, these changes need to be generated. Should we also update the example agent scripts in llama-stack-apps repo?

@ehhuang
Copy link
Contributor Author

ehhuang commented Feb 6, 2025

synced change in #126

@ehhuang ehhuang closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanxi0830 yanxi0830 yanxi0830 requested changes

@raghotham raghotham raghotham approved these changes

@ashwinb ashwinb Awaiting requested review from ashwinb ashwinb is a code owner

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@dineshyv dineshyv Awaiting requested review from dineshyv dineshyv is a code owner

@vladimirivic vladimirivic Awaiting requested review from vladimirivic vladimirivic is a code owner

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ehhuang @raghotham @yanxi0830 @facebook-github-bot