Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update paddings #85

Merged
merged 5 commits into from
Aug 11, 2023
Merged

Update paddings #85

merged 5 commits into from
Aug 11, 2023

Conversation

HamidShojanazeri
Copy link
Contributor

@HamidShojanazeri HamidShojanazeri commented Aug 2, 2023

What does this PR do?

This PR adds the update for padding with new tokenizer changes which requires change in embedding size.

Fixes # (issue)

Feature/Issue validation/testing

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

Before submitting

  • [ X] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • [ X] Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Thanks for contributing 🎉!

Copy link
Contributor

@chauhang chauhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HamidShojanazeri Thanks for this PR. Please add documentation updates explaining the usage and in which scenario padding will be needed. At present a bunch on new warning messages are getting printed based on the values passed for the max_padding_length parameter and no change in the generated output.

@chauhang chauhang merged commit 03faba6 into main Aug 11, 2023
3 checks passed
@chauhang chauhang deleted the update_paddings branch August 26, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants