Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package distribution #153

Merged
merged 56 commits into from
Sep 6, 2023
Merged

Package distribution #153

merged 56 commits into from
Sep 6, 2023

Conversation

mreso
Copy link
Contributor

@mreso mreso commented Aug 30, 2023

What does this PR do?

This PR prepared the repo in a way that llama-recipes can be distributed as a package for easier usage and development.
For this the following changes are made:

  • Move source files int src/llama_recipes
  • Add pyproject.toml for building wheel
  • Make script runnable with python -m
  • Adopt documentation
  • Adding basic unit tests

Fixes # (issue)
-NA-

Before submitting

  • Did you read the contributor guideline,
    Pull Request section?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Thanks for contributing 🎉!

@mreso mreso marked this pull request as ready for review September 1, 2023 22:37
@mreso mreso changed the title [WIP] Package distribution Package distribution Sep 2, 2023
Copy link
Contributor

@chauhang chauhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mreso Thanks for getting packaging sol started. Great to see pip install option and unit tests added. Please look into adding a contributors readme as well for developers with a section on unit tests and how to add new tests.

The main inference example does not seem to generating the summary correctly. Please check if anything has changed there.

Left few other comments inline.

docs/inference.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/inference.md Outdated Show resolved Hide resolved
docs/inference.md Outdated Show resolved Hide resolved
examples/README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@chauhang chauhang merged commit c000c87 into main Sep 6, 2023
3 checks passed
@chauhang chauhang linked an issue Sep 6, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installable (PyPi) version of the library?
3 participants