Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LLM_finetuning.md #149

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Update LLM_finetuning.md #149

merged 4 commits into from
Sep 13, 2023

Conversation

varunfb
Copy link
Contributor

@varunfb varunfb commented Aug 29, 2023

Added missing link to learning more about FSDP and getting started with FSDP.

What does this PR do?

Updated the documentation for FSDP.

Fixes # (issue)
N/A

Feature/Issue validation/testing

Verified by looking at the preview of the file.

Before submitting

  • [X ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Thanks for contributing 🎉!

@HamidShojanazeri
Copy link
Contributor

@varunfb can you pls make sure spell check is passing as well. Word list can be found here.

Copy link
Contributor

@mreso mreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mreso mreso merged commit cfacee4 into meta-llama:main Sep 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants