Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "load_model_sharded" when "--save_optimizer" enabled #128

Closed
wants to merge 1 commit into from

Conversation

abhika-m
Copy link

Fixing "key error" when loading optimizer with sharded checkpoint loading

Potentially Fixes # 127

Feature/Issue validation/testing

  • Enabled "save_optimizer" then ran training with StateDictType.SHARDED_STATE_DICT for one epoch then loaded from checkpoint
  1. Ran for one epoch:
python ./llama_finetuning.py ... --save_optimizer
  1. Loaded from checkpoint created:
load_model_sharded(model, rank, cfg)
  1. Loading checkpoints resulted in:
checkpoint key len = 1 and 
keys =  dict_keys(['model'])

If "--save_optimizer" is enabled then checkpoint key length should be "2" and keys should be "dict_keys(['model', 'optim'])

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@facebook-github-bot
Copy link

Hi @abhika-m!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants