Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: D2iQ Build Environment Fixes. #4

Merged
merged 7 commits into from
Jan 9, 2024
Merged

fix: D2iQ Build Environment Fixes. #4

merged 7 commits into from
Jan 9, 2024

Conversation

kaiwalyajoshi
Copy link

Change log description

Update build scaffolding for GHCR images.

  • Use ghcr.io as registry.
  • Remove image pushes to external org repositories like emccorp and pravega
  • Enable workflow_dispatch for CI GHA to test changes.
  • Disable codecov which is failing.
  • Remove docker-login which will override GHCR logins.

Purpose of the change

(e.g., Fixes #666, Closes #1234)

What the code does

(Detailed description of the code changes)

How to verify it

(Steps to verify that the changes are effective)

@kaiwalyajoshi kaiwalyajoshi mentioned this pull request Jan 9, 2024
Open
@kaiwalyajoshi kaiwalyajoshi merged commit 9d707c8 into master Jan 9, 2024
2 checks passed
@kaiwalyajoshi kaiwalyajoshi mentioned this pull request Jan 9, 2024
Merged
@kaiwalyajoshi kaiwalyajoshi deleted the kjoshi/d2iq-build-env-fixes branch January 9, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asekretenko asekretenko asekretenko approved these changes

@mikolajb mikolajb mikolajb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaiwalyajoshi @mikolajb @asekretenko