Skip to content

Commit

Permalink
chore: Add CODEOWNERS file. Revert to ubuntu-latest.
Browse files Browse the repository at this point in the history
  • Loading branch information
kaiwalyajoshi committed Jan 9, 2024
1 parent 7ec481b commit ab89577
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 11 deletions.
3 changes: 3 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Reference: https://help.github.com/en/articles/about-code-owners
# Order is important: later rules override preceding rules
* @mesosphere/kommander
20 changes: 14 additions & 6 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ on:
jobs:
build:
runs-on:
- self-hosted
- large
- ubuntu-latest
steps:
- name: Set up Go 1.21
uses: actions/setup-go@v2
Expand All @@ -38,8 +37,9 @@ jobs:
run: make check
- name: unit tests
run: make test
- name: Codecov
uses: codecov/[email protected]
# This fails
# - name: Codecov
# uses: codecov/[email protected]
- name: Set env
run: |
echo "KUBERNETES_VERSION=v1.23.1" >> $GITHUB_ENV
Expand Down Expand Up @@ -70,12 +70,20 @@ jobs:
run: sudo make test-e2e
publish:
name: Publish docker image
permissions:
contents: read
packages: write
runs-on:
- self-hosted
- large
- ubuntu-latest
needs: build
if: github.event_name == 'release' && github.event.action == 'created'
steps:
- name: Login to GHCR
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Pushing docker images
run: sudo make push
- name: Uploading binary files
Expand Down
9 changes: 4 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ EXPORTER_NAME=zookeeper-exporter
APP_NAME=zookeeper
RELEASE_REGISTRY ?= ghcr.io
REPO=mesosphere/$(PROJECT_NAME)
TEST_REPO=mesosphere/$(PROJECT_NAME)
TEST_REPO=testzkop/$(PROJECT_NAME)
APP_REPO=mesosphere/$(APP_NAME)
VERSION=$(shell git describe --always --tags --dirty | tr -d "v" | sed "s/\(.*\)-g`git rev-parse --short HEAD`/\1/")
GIT_SHA=$(shell git rev-parse --short HEAD)
TEST_IMAGE=$(TEST_REPO):testimages-$(VERSION)
TEST_IMAGE=$(TEST_REPO)-testimages:$(VERSION)
DOCKER_TEST_PASS=testzkop@123
DOCKER_TEST_USER=testzkop
.PHONY: all build check clean test
Expand Down Expand Up @@ -48,7 +48,6 @@ deploy: manifests kustomize
cd config/manager && $(KUSTOMIZE) edit set image pravega/zookeeper-operator=$(TEST_IMAGE)
$(KUSTOMIZE) build config/default | kubectl apply -f -


# Deploy controller in the configured Kubernetes cluster in ~/.kube/config
deploy-test: manifests kustomize
cd config/test
Expand Down Expand Up @@ -106,7 +105,7 @@ generate:
echo '{{- end }}' >> charts/zookeeper-operator/templates/zookeeper.pravega.io_zookeeperclusters_crd.yaml


build: test build-go build-image
build: test build-go build-image build-zk-image

build-go:
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build \
Expand Down Expand Up @@ -168,7 +167,7 @@ login:
test-login:
echo "$(DOCKER_TEST_PASS)" | docker login -u "$(DOCKER_TEST_USER)" --password-stdin

push: build-image build-zk-image login
push: build-image build-zk-image
docker push $(RELEASE_REGISTRY)/$(REPO):$(VERSION)
docker push $(RELEASE_REGISTRY)/$(REPO):latest
docker push $(RELEASE_REGISTRY)/$(APP_REPO):$(VERSION)
Expand Down

0 comments on commit ab89577

Please sign in to comment.