Skip to content

Commit

Permalink
fix: Do not upx pack darwin binaries (#342)
Browse files Browse the repository at this point in the history
  • Loading branch information
jimmidyson authored Feb 22, 2023
1 parent 551f3bf commit e9d172d
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions make/upx.mk
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,8 @@ upx: UPX_REAL_TARGET := $(addsuffix $(if $(filter $(GOOS),windows),.exe),$(basen
ifneq ($(SKIP_UPX),true)
ifeq ($(GOOS)/$(GOARCH),windows/arm64)
upx: ; $(info $(M) skipping packing $(UPX_REAL_TARGET) - $(GOOS)/$(GOARCH) is not yet supported by upx)
# TODO Remove once upx 4.0.2 is released
else ifeq ($(GOOS)/$(GOARCH),darwin/arm64)
upx: ; $(info $(M) skipping packing $(UPX_REAL_TARGET) - $(GOOS)/$(GOARCH) has a bug in packing - https://github.com/upx/upx/issues/628 - should be fixed in 4.0.2)
else ifeq ($(GOOS),darwin)
upx: ; $(info $(M) skipping packing $(UPX_REAL_TARGET) - $(GOOS) has a bug in packing especially on Ventura - https://github.com/upx/upx/issues/612)
else
upx: install-tool.upx
upx: ## Pack executable using upx
Expand Down

0 comments on commit e9d172d

Please sign in to comment.