Skip to content

Commit

Permalink
fix: Clarify help text for CA certs (#236)
Browse files Browse the repository at this point in the history
  • Loading branch information
jimmidyson committed Oct 20, 2022
1 parent 4533a06 commit 8faea4f
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion cmd/mindthegap/push/helmbundle/helm_bundle.go
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ func NewCommand(out output.Output) *cobra.Command {
cmd.Flags().StringVar(&destRegistry, "to-registry", "", "Registry to push images to")
_ = cmd.MarkFlagRequired("to-registry")
cmd.Flags().BoolVar(&destRegistrySkipTLSVerify, "to-registry-insecure-skip-tls-verify", false,
"Skip TLS verification of registry to push images to (use for http registries)")
"Skip TLS verification of registry to push images to (also use for non-TLS http registries)")
cmd.Flags().StringVar(&destRegistryUsername, "to-registry-username", "",
"Username to use to log in to destination repository")
cmd.Flags().StringVar(&destRegistryPassword, "to-registry-password", "",
Expand Down
4 changes: 2 additions & 2 deletions cmd/mindthegap/push/imagebundle/image_bundle.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,9 @@ func NewCommand(out output.Output) *cobra.Command {
cmd.Flags().StringVar(&destRegistry, "to-registry", "", "Registry to push images to")
_ = cmd.MarkFlagRequired("to-registry")
cmd.Flags().StringVar(&destRegistryCACertificateFile, "to-registry-ca-cert-file", "",
"CA certificate file used to verify TLS verification of registry to push images to (use for http registries)")
"CA certificate file used to verify TLS verification of registry to push images to")
cmd.Flags().BoolVar(&destRegistrySkipTLSVerify, "to-registry-insecure-skip-tls-verify", false,
"Skip TLS verification of registry to push images to (use for non-TLS http registries)")
"Skip TLS verification of registry to push images to (also use for non-TLS http registries)")
cmd.MarkFlagsMutuallyExclusive(
"to-registry-ca-cert-file",
"to-registry-insecure-skip-tls-verify",
Expand Down
2 changes: 1 addition & 1 deletion cmd/push/imagebundle/image_bundle.go
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ func NewCommand(out output.Output) *cobra.Command {
cmd.Flags().StringVar(&destRegistry, "to-registry", "", "Registry to push images to")
_ = cmd.MarkFlagRequired("to-registry")
cmd.Flags().BoolVar(&destRegistrySkipTLSVerify, "to-registry-insecure-skip-tls-verify", false,
"Skip TLS verification of registry to push images to (use for http registries)")
"Skip TLS verification of registry to push images to (also use for non-TLS http registries)")
cmd.Flags().StringVar(&destRegistryUsername, "to-registry-username", "",
"Username to use to log in to destination registry")
cmd.Flags().StringVar(&destRegistryPassword, "to-registry-password", "",
Expand Down

0 comments on commit 8faea4f

Please sign in to comment.