Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downstream patches for 1.1.0-1 release branch #8

Merged
merged 13 commits into from
Sep 22, 2023

Commits on Sep 19, 2023

  1. fix: make cloud-init script compatible with KIB generated images

    shalin patel authored and dlipovetsky committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    54932e2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    44d1867 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    511a583 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d07e9a3 View commit details
    Browse the repository at this point in the history
  5. build: Create GitHub release with artifacts

    Co-authored-by: shalin patel <[email protected]>
    dlipovetsky and shalin patel committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    dc6d4e8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    78a1cf2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    32d6b3b View commit details
    Browse the repository at this point in the history
  8. build: Continue to build multi-arch container image

    Upstream stopped building the executable in a container. We continue to
    build it in a container, so that we can have multi-arch images.
    dlipovetsky committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e2a699b View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. fix: Sync the VCDMachine v1beta1 CRD with the go type

    A recent PR[1] updated the godoc comment that describes the
    VCDMachineSpec MachineAddress field, but the change was not reflected in
    the v1beta1 CRD.
    
    This updates the comment in the CRD base, as well as
    infrastructure-components.yaml
    
    [1]: vmware#445
    dlipovetsky committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    80c0b0a View commit details
    Browse the repository at this point in the history
  2. fix: Completely execute the test make target

    make runs each line in a separate shell. In a recent commit[1], commands
    on one line were split to multiple lines. When `go test` ran, it did not
    have the environment variable required by envtest, and failed.
    
    [1]: https://github.com/vmware/cluster-api-provider-cloud-director/pull/466/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R129-R134
    dlipovetsky committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    b294621 View commit details
    Browse the repository at this point in the history
  3. fix: Use absolute path for envtest assets

    A recent PR[1] introduced the use of a relative path for envtest assets.
    The path is relative to the repository root, and this means Go tests,
    which run relative to their package path, cannot find the envtest
    assets, and fail.
    
    [1]: https://github.com/vmware/cluster-api-provider-cloud-director/pull/466/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R129-R134
    dlipovetsky committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    50cba1b View commit details
    Browse the repository at this point in the history
  4. build: Allow test make target to test a subset of packages

    It is sometimes necessary to skip some tests. For example, to skip the
    e2e tests, run:
    
    ```shell
    make test TEST_PACKAGES='$(shell go list ./... | grep -v 'tests/e2e')'
    ```
    dlipovetsky committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    771c7d0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    424db45 View commit details
    Browse the repository at this point in the history