Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for history service + api #958

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Docs for history service + api #958

wants to merge 1 commit into from

Conversation

sascala
Copy link
Contributor

@sascala sascala commented Mar 14, 2017

Description

Urgency

  • Blocker
  • High
  • Medium

Requirements

@sascala sascala self-assigned this Mar 14, 2017
@sascala sascala requested a review from amitaekbote March 14, 2017 23:06
@sascala
Copy link
Contributor Author

sascala commented Mar 14, 2017

@amitaekbote It looks like your team is responsible for the history service -- if that's correct, would you mind giving this a quick look over to make sure it's correct? I took the information from here: https://github.com/dcos/dcos/tree/master/packages/dcos-history/extra

And you can view the rendered swagger by pasting the file into http://editor.swagger.io.

@karlkfi
Copy link
Contributor

karlkfi commented Mar 15, 2017

Is it worth putting this in without a page to display it on? or should we just get it upstreamed to the dcos repo first?

@sascala sascala changed the title swagger doc for history service api Docs for history service + api Mar 15, 2017
@sascala
Copy link
Contributor Author

sascala commented Mar 15, 2017

@karlkfi my plan is to get the API checked out while I figure out where the best place is for the accompanying document.

@amitaekbote
Copy link
Contributor

this looks good to me 🚢

@sascala
Copy link
Contributor Author

sascala commented Jan 18, 2018

@pavisandhu this is swagger for the history service, which couldn't be documented at the time of creation. Amita is the authority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants