use erikdw/storm's patched version of storm 0.9.6 to build storm-mesos package #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s package Per the [release notes in erikdw/storm](https://github.com/erikdw/storm/releases) there are a few tweaks that have been made to storm to make it more friendly for running storm-mesos: 1. Per-topology worker logs 2. Shorten java classpaths in various commands to ensure ps output includes full command 3. Flush bin/storm output output before exec'ing java process
|
@JessicaLHartog : please 👀 when you have a chance. This has been tested in erikdw/storm-mesos, which is why I had to fix #149 & #150 first, in order to actually test this. :) |
|
Once this is reviewed, I will release the next version of this project. Then when #146 lands we will cut another version. That should then free us to do the branch split that will allow support for storm 1.0 to proceed. |
|
LGTM, but out of sheer curiosity, why is the file name |
|
'cause it's the 2nd release. :) We'll do more if we need to iterate more. This comes from: |
|
Makes sense, thanks for clarifying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the release notes in erikdw/storm there are
a few tweaks that have been made to storm to make it more friendly for running storm-mesos: