Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdl2: disable unity builds #1329

Closed
wants to merge 2 commits into from

Conversation

takase1121
Copy link
Contributor

Unity builds doesn't seem to work with SDL2, it throws a bunch of build errors.
Please advise if this isn't the correct way to disable it, and I should disable it when including SDL2 as a dependency, etc.

@jpakkane
Copy link
Member

jpakkane commented Dec 8, 2023

You should use override_options on the target itself.

@takase1121
Copy link
Contributor Author

Sorry, I didn't fully understand that - does that mean I should disable unity builds on the target that uses SDL2? I'm still pretty novice when it comes to meson.

@jpakkane
Copy link
Member

jpakkane commented Dec 9, 2023

You should add that override on the target that can't be built as a unity build, in this case to the main SDL2 library target. Relevant doc link.

@takase1121
Copy link
Contributor Author

If I understood correctly, this means I should put override_options on only sdl2_dep (which contains the sdl2 library target).

@jpakkane
Copy link
Member

jpakkane commented Dec 9, 2023

No, to the target that defines the SDL 2 library. What it means is "this target that is currently being defined can not be built in unity mode so do not use it for this target even if it has been enabled globally".

@takase1121 takase1121 closed this Mar 2, 2024
@eli-schwartz
Copy link
Member

Any particular reason this was closed?

Note that this should really bump the revision in releases.json...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants