dependencies/jni: Properly resolve jni dependency on android #14225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcbaker
requested changes
Feb 6, 2025
sp1ritCS
force-pushed
the
android_jni
branch
3 times, most recently
from
7b4db8e to
183a8d7
Compare
tristan957
reviewed
Feb 7, 2025
tristan957
reviewed
Feb 7, 2025
|
Thanks for your work on this. I agree that this is good dev X |
tristan957
reviewed
Feb 7, 2025
The NDK has a jni.h in sysroot/usr/include/, there are no extra native modules that provide any callable symbols.
tristan957
approved these changes
Feb 10, 2025
|
Ready to go @dcbaker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm unhappy with the error messages, please suggest better ones