-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zig linker support #13515
Add zig linker support #13515
Conversation
Please don't use merge commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, merge commits are explicitly a violation of the Contributing docs: https://mesonbuild.com/Contributing.html#keeping-pull-requests-up-to-date
We will NOT merge any PR that contains one.
Sorry, didn't know that one. Should I squash/cherry pick instead? |
Zig issue ziglang/zig#18713
5af01c0
to
e8bd64b
Compare
ci/ciimage/ubuntu-rolling/install.sh
Outdated
@@ -50,6 +51,18 @@ dub_fetch dubtestproject | |||
dub build dubtestproject:test1 --compiler=ldc2 | |||
dub build dubtestproject:test2 --compiler=ldc2 | |||
|
|||
# zig | |||
|
|||
ZIG_ARCHIVE=$(wget -qO- https://ziglang.org/download/index.json | jq -r ".master[\"$(uname -m)-linux\"].tarball") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we want to pull master for this. That'll lead to flaky CI. If we do want that, it needs justification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we can probably use the latest release instead of master. I just need to figure out the jq to read the 2nd object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, we're now using a tagged release instead of master.
e8bd64b
to
53f388c
Compare
Zig is in the CI image now, I think, so this just needs a rebase and dropping that last commit? |
53f388c
to
97f06ca
Compare
Done |
Adds support for Zig's linker (zld)
Merges #13493, #12293, and #12953.
Context from #13493 (comment)