Actionable Notifications #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new PR |
powersjcb
reviewed
Sep 8, 2024
| let replyInputAction = UNTextInputNotificationAction( | ||
| identifier: "messageNotification.replyInputAction", | ||
| title: "reply".localized, | ||
| options: []) |
There was a problem hiding this comment.
indentation in this diff off. Can we fix this by running the linter?
| identifier: "messageNotificationCategory", | ||
| actions: [thumbsUpAction, thumbsDownAction,replyInputAction], | ||
| intentIdentifiers: [], | ||
| options: .customDismissAction |
| if let userInput = (response as? UNTextInputNotificationResponse)?.userText, | ||
| let channel = userInfo["channel"] as? Int32, | ||
| let replyID = userInfo["messageId"] as? Int64 { | ||
| let tapbackResponse = !BLEManager.shared.sendMessage( |
There was a problem hiding this comment.
Two questions here:
- It looks like for each of these the variable
tapbackResponseis never used. Can they be removed? - Do we need to consider any edge-cases that could cause this to crash? (ie: BLE is disconnected)
There was a problem hiding this comment.
sendMessage returns a boolean if it fails or goes through. For logging purposes we could use it.
|
Merging into a branch in the repo for testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Creates Actionable notifications for DMs and channel messages. Includes thumbs down/up tapbacks and reply.
Why did it change?
Useful for quite responses and watch OS.
How is this tested?
on my iPhone
Screenshots/Videos (when applicable)
Checklist