Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange Position Response Notifications #833

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

garthvh
Copy link
Member

@garthvh garthvh commented Aug 2, 2024

Notification that a new position sent as a DM as been received

  • Only show the notification for DM's
  • Only Show the notification for DM's sent to the connected node
  • Open the notification in the node map view using the NavigationState passed in from the notification

@garthvh garthvh marked this pull request as draft August 2, 2024 04:32
@garthvh garthvh requested a review from 72A12F4E August 2, 2024 04:32
let detail = components.queryItems?
.first(where: { $0.name == "detail" })?
.value
route(to: .nodes(NodeListNavigationState(selectedNodeNum: nodeId, details: detail != nil ? NodeDetails(rawValue: detail!) : nil)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to force unwrap, just use a map

route(
    to: .nodes(
        NodeListNavigationState(
            selectedNodeNum: nodeId, 
            details: detail?.map(NodeDetails.init(rawValue:))
        )
    )
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants