Improve error logs related to invalid source url in model generation

generators/github/error.go

@@ -9,6 +9,8 @@ import (
 const (
 	ErrGenerateGitHubPackageCode  = "meshkit-11139"
 	ErrInvalidGitHubSourceURLCode = "meshkit-11140"
+	ErrInvalidProtocolCode        = "meshkit-11311"
+	ErrFetchingContentfromURLCode = "meshkit-11312"
 )
 
 func ErrGenerateGitHubPackage(err error, pkgName string) error {
@@ -18,3 +20,11 @@ func ErrGenerateGitHubPackage(err error, pkgName string) error {
 func ErrInvalidGitHubSourceURL(err error) error {
 	return errors.New(ErrInvalidGitHubSourceURLCode, errors.Alert, []string{}, []string{err.Error()}, []string{"sourceURL provided might be invalid", "provided repo/version tag does not exist"}, []string{"ensure source url follows the format: git://<owner>/<repositoryname>/<branch>/<version>/<path from the root of repository>"})
 }
+
+func ErrInvalidProtocol(err error, pkgName string, protocol string) error {
+	return errors.New(ErrInvalidProtocolCode, errors.Alert, []string{fmt.Sprintf("Unsupported protocol used in source URL for %s", pkgName)}, []string{fmt.Sprintf("Unsupported protocol used in source URL for %s. Error details: %s", pkgName, err.Error())}, []string{fmt.Sprintf("The URL scheme '%s' used in %s is not supported", protocol, pkgName)}, []string{"The 'git' protocol is supported for GitHub repositories.", "Refer to documentation for more details: https://docs.meshery.io/project/contributing/contributing-models#instructions-for-creating-a-new-model"})
+}
+
+func ErrFetchingContentfromURL(err error) error {
+	return errors.New(ErrFetchingContentfromURLCode, errors.Alert, []string{"Error fetching contents from provided source URL"}, []string{fmt.Sprintf("Error fetching contents from provided link to repository. Error details: %s", err.Error())}, []string{"Provided source URL might not follow a valid Git protocol URL format.", "It might have components like `/blob/` or `/tree/`, which are used for viewing files or folders in the browser, not for accessing the repository itself.", "The manifests are in compressed formats like .tgz or .zip"}, []string{"Ensure source URL follows the correct Git protocol format: git://[owner]/[repositoryname]/[branch]/[version]/[path-from-the-root-of-repository]", "Ensure that manifests are in an uncompressed form", "Refer to documentation for more details: https://docs.meshery.io/project/contributing/contributing-models#instructions-for-creating-a-new-model"})
+}

generators/github/git_repo.go

@@ -33,7 +33,7 @@ func (gr GitRepo) GetContent() (models.Package, error) {
 
 	versions, err := utils.GetLatestReleaseTagsSorted(owner, repo)
 	if err != nil {
-		return nil, ErrInvalidGitHubSourceURL(err)
+		return nil, err
 	}
 	version := versions[len(versions)-1]
 	dirPath := filepath.Join(os.TempDir(), owner, repo, branch)

generators/github/package_manager.go

@@ -22,11 +22,11 @@ func (ghpm GitHubPackageManager) GetPackage() (models.Package, error) {
 
 	downloader := NewDownloaderForScheme(protocol, url, ghpm.PackageName)
 	if downloader == nil {
-		return nil, ErrGenerateGitHubPackage(err, ghpm.PackageName)
+		return nil, ErrInvalidProtocol(err, ghpm.PackageName, protocol)
 	}
 	ghPackage, err := downloader.GetContent()
 	if err != nil {
-		return nil, ErrGenerateGitHubPackage(err, ghpm.PackageName)
+		return nil, ErrFetchingContentfromURL(err)
 	}
 	return ghPackage, nil
 }