Skip to content

Add metadata field to Models table #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 20, 2023
Merged

Conversation

Revolyssup
Copy link
Contributor

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@leecalcote
Copy link
Member

@Revolyssup, what steps can we start to take to be schema-driven here? @MUzairS15 @theBeginner86 @deepakdinesh1123

@@ -21,12 +22,22 @@ type ModelFilter struct {

// swagger:response Model
type Model struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Revolyssup, educate me: what's the difference between Model and ModelDB?

@leecalcote
Copy link
Member

@Revolyssup, what steps can we start to take to be schema-driven here? @MUzairS15 @theBeginner86 @deepakdinesh1123

What do you know? @Revolyssup is on top of it with a first step here - #273

Signed-off-by: Ashish Tiwari <[email protected]>
Signed-off-by: Ashish Tiwari <[email protected]>
Signed-off-by: Ashish Tiwari <[email protected]>
Signed-off-by: Ashish Tiwari <[email protected]>
Signed-off-by: Ashish Tiwari <[email protected]>
Signed-off-by: Ashish Tiwari <[email protected]>
Signed-off-by: Ashish Tiwari <[email protected]>
Signed-off-by: Ashish Tiwari <[email protected]>
Signed-off-by: Ashish Tiwari <[email protected]>
@Revolyssup Revolyssup merged commit 0474e31 into meshery:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants