Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename pattern to design command in mesheryctl #10603

Closed
wants to merge 14 commits into from
Closed

Rename pattern to design command in mesheryctl #10603

wants to merge 14 commits into from

Conversation

alphaX86
Copy link
Member

@alphaX86 alphaX86 commented Mar 23, 2024 •
edited
Loading

Notes for Reviewers

This PR fixes #10592

PR in progress! Please don't merge! Ready for review!

Checklist:

  • Basic name change in all files and test files
  • Test design command test files
    • Unit tests
    • Test in real time
      • apply
      • delete
      • list
      • view
      • onboard
      • offboard
  • Verify if results are same as pattern in both tests as well as real usage (in progress)
  • Complete rename of command
  • Update docs
    • Update index entry (TBD for other commands)
    • Generate doc pages for dry run

Signed commits

  • Yes, I signed my commits.

@alphaX86 alphaX86 added pr/do-not-merge PRs not ready to be merged pr/draft WIP/Draft pull request labels Mar 23, 2024
@github-actions github-actions bot added the component/mesheryctl CLI for Meshery label Mar 23, 2024
@alphaX86 alphaX86 changed the title Rename pattern to design command Rename pattern to design command in mesheryctl Mar 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 23, 2024 •
edited
Loading

@leecalcote
Copy link
Member

Syncing with master.

@MUzairS15
Copy link
Contributor

@alphaX86 are the checklist in the PR description up-to-date ? Have you performed the testing? // @RipulHandoo

@leecalcote
Copy link
Member

Current status:

Screenshot 2024-04-11 at 12 02 31 AM

@leecalcote
Copy link
Member

@lekaf974, you might like to offer review on this PR.

@github-actions github-actions bot added the area/docs Documentation update needed label Apr 11, 2024
@l5io
Copy link
Collaborator

l5io commented Apr 11, 2024

🚀 Preview for commit da949ee at: https://66177fc7d2eb21462f381180--meshery-docs-preview.netlify.app

@alphaX86
Make changes
8edfa1c 
Signed-off-by: Aadhitya A <[email protected]>
@l5io
Copy link
Collaborator

l5io commented Apr 11, 2024

🚀 Preview for commit 8edfa1c at: https://66178e53a5c6bf51632114c5--meshery-docs-preview.netlify.app

@l5io
Copy link
Collaborator

l5io commented Apr 11, 2024

🚀 Preview for commit f22186a at: https://661792bbe2505556cdf25ffd--meshery-docs-preview.netlify.app

@l5io
Copy link
Collaborator

l5io commented Apr 11, 2024

🚀 Preview for commit be65353 at: https://6617b87dd731856ffd34ab3f--meshery-docs-preview.netlify.app

@l5io
Copy link
Collaborator

l5io commented Apr 11, 2024

🚀 Preview for commit 7209cd7 at: https://6617bb7bd2eb21799437ea93--meshery-docs-preview.netlify.app

@alphaX86
Fix spacings in test files
249b56f 
Signed-off-by: Aadhitya A <[email protected]>
@l5io
Copy link
Collaborator

l5io commented Apr 11, 2024

🚀 Preview for commit 249b56f at: https://6617c1fbe4aa377f710ae663--meshery-docs-preview.netlify.app

@alphaX86
Add doc pages for dry run
9a64556 
Signed-off-by: Aadhitya A <[email protected]>
@l5io
Copy link
Collaborator

l5io commented Apr 11, 2024

🚀 Preview for commit 9a64556 at: https://6617c59f3809227db6ba47d8--meshery-docs-preview.netlify.app

@l5io
Copy link
Collaborator

l5io commented Apr 14, 2024

🚀 Preview for commit a3be89d at: https://661bc0b99f80c443ac3260d7--meshery-docs-preview.netlify.app

@alphaX86 alphaX86 added component/patterns and removed pr/do-not-merge PRs not ready to be merged pr/draft WIP/Draft pull request labels Apr 14, 2024
@alphaX86 alphaX86 requested review from leecalcote, MUzairS15, a team and lekaf974 April 14, 2024 11:58
@l5io
Copy link
Collaborator

l5io commented Apr 14, 2024

🚀 Preview for commit 83e9f87 at: https://661becf6740ddc7ef1de1a19--meshery-docs-preview.netlify.app

leecalcote
leecalcote reviewed Apr 16, 2024
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff here, @alphaX86. Will you confirm that each of the GitHub workflows (https://github.com/meshery/meshery/tree/master/.github) that reference mesheryctl pattern have been updated as well?

Please consider this GitHub Action, too:

  1. https://github.com/layer5io/meshery-smp-action
  2. https://github.com/layer5labs/meshmap-snapshot

@leecalcote
Copy link
Member

Great checklist, @alphaX86

@leecalcote
Copy link
Member

Good stuff here, @alphaX86. Will you confirm that each of the GitHub workflows (https://github.com/meshery/meshery/tree/master/.github) that reference mesheryctl pattern have been updated as well?

Please consider this GitHub Action, too:

  1. https://github.com/layer5io/meshery-smp-action
  2. https://github.com/layer5labs/meshmap-snapshot

@alphaX86, were you able to verify these and upgrade them?

@lekaf974
Copy link
Contributor

lekaf974 commented May 7, 2024

@lekaf974, you might like to offer review on this PR.

Sure taking a look

@alphaX86
Copy link
Member Author

Resyncing PR...

@alphaX86
Resync files
c446132 
Signed-off-by: Aadhitya A <[email protected]>
lekaf974
lekaf974 reviewed May 13, 2024
View reviewed changes
mesheryctl/internal/cli/root/design/testdata/offboard.output.golden
@@ -1,3 +1,3 @@
pattern file converted to pattern file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does pattern ok here or need to be rename to design ?

lekaf974
lekaf974 reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@lekaf974 lekaf974 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took time to check and LGTM also I am not involve from enough time to be sure there are nothing that missing

This was referenced May 16, 2024
Closed
Merged
@leecalcote
Copy link
Member

@alphaX86 how are we doing on this diligence? --> #10603 (review)

@alphaX86 alphaX86 closed this by deleting the head repository May 26, 2024
@alphaX86
Copy link
Member Author

PR staled. Reopening a new one with synced changes

alphaX86 added a commit that referenced this pull request May 26, 2024
@alphaX86
Resync PR #10603
344bed2 
Signed-off-by: Aadhitya A <[email protected]>
@alphaX86 alphaX86 mentioned this pull request May 26, 2024
Open
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lekaf974 lekaf974 lekaf974 left review comments

@leecalcote leecalcote leecalcote left review comments

@RipulHandoo RipulHandoo Awaiting requested review from RipulHandoo

@MUzairS15 MUzairS15 Awaiting requested review from MUzairS15

Assignees
No one assigned
Labels
area/docs Documentation update needed component/mesheryctl CLI for Meshery component/patterns
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mesheryctl] Rename pattern to design command
5 participants
@alphaX86 @leecalcote @MUzairS15 @l5io @lekaf974