-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Website] : Improve Lighthouse Score #1564
Conversation
Signed-off-by: Akshun-01 <[email protected]>
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @Akshun-01 Let's discuss this on website call today at 6:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes. |
@Akshun-01 Thankyou for raising a draft PR, can you share the progress here? |
Hey @Yashsharma1911, I was confused about this one. |
There can be a couple of solutions you might like to read this blog https://developer.chrome.com/docs/lighthouse/performance/uses-responsive-images, I guess it's about serving image that is appropriate to screen it can differ based on resolution I'll recommend to not hander the original image but rather creating a different size version of original images and you can use |
Signed-off-by: Akshun-01 <[email protected]>
…/meshery.io into improveLighthouseScore
Signed-off-by: Akshun-01 <[email protected]>
…/meshery.io into improveLighthouseScore
@Yashsharma1911, I don't think we can improve it much now, as it is already touching 70 now. It would need lot of optimizations to reach to 80. So, how should we proceed with the issue? |
Thankyou @Akshun-01 it would be nice if you can present this in tomorrows website meeting |
@Akshun-01 any update here? |
@Raj100679 would you like to review this PR |
@Yashsharma1911 I don't have much experience at reviewing , but I will need to check what the issue is, then I will review it at night, Thanks |
Hey @Yashsharma1911 , I tried some other suggestions given by the report. But now rather than increasing it is rather going the opposite way. @Raj100679 would appreciate your feedback and insight on this! |
@Akshun-01 Sorry I am stuck with some other work, @Yashsharma1911 Can you check it |
Thanks for working through this, @Akshun-01. |
@Akshun-01 still working on this? |
Got any solution? |
following up again, @Akshun-01 are you still working on this? |
Hi @sudhanshutech, sorry for the late reply. Actually, I was waiting for someone to review the already-made changes. So, I think pointlessly making any more image compressions or putting a lot of time into scaling images is fruitful only if we believe that would make a great difference. |
@Yashsharma1911 If you or anyone else could take out some time. It would be great! |
Great thanks then, I'll look in the evening, till I'll suggest you to parallel work on others issues too if you want as this seems to block you. Message from mobile |
Yeah, I was stuck with a lot lately. So didn't get time. I will start with other issues as well now. Also, I wanted to help in the backend part too, so if you know any beginner-friendly ones, I would appreciate it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Akshun-01 quality of this homepage GIF becomes too poor
Yeah, it's not good. |
sounds helpful @Akshun-01 , before creating a pr it would be good if you have documented the changes first like what is the issues and what is the solution and series them according them to priority. So in this way it will not take that much time and will easy to review. |
Description
Change video format from .gif to .webp
This PR fixes #973
Notes for Reviewers
I would delete the original .gif files during final push, for now I have left them as it is!
Signed commits