Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Upgraded Server Initialization method for e2e Test #656

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

singh1203
Copy link
Contributor

Description

This PR fixes #645

  • Upgraded server initialization method according to Adapter-library v0.7.0

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link

welcome bot commented Jan 28, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@singh1203
Copy link
Contributor Author

This PR is dependent on #655 and meshery/meshery#10114.

@MUzairS15
Copy link

The adapter library has been updated, we can merge now.

@MUzairS15 MUzairS15 merged commit e02a509 into meshery:master Feb 16, 2024
6 checks passed
Copy link

welcome bot commented Feb 16, 2024

Thanks for your contribution to the Meshery! 🎉

Meshery Celebration logo
        Join the community, if you haven't yet and please leave a ⭐ star on the project. 😄

@singh1203
Copy link
Contributor Author

Thank you for Merging @MUzairS15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Failing E2E test
2 participants