Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: workload identity federation #29

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

henryde
Copy link
Contributor

@henryde henryde commented Mar 19, 2024

Allow metering and replicator service principals to use workload identity federation instead of passwords.

@henryde henryde requested a review from malhussan March 19, 2024 09:47
@henryde henryde force-pushed the feature/workload-identity-federation branch 2 times, most recently from 7ef58b6 to 316c0da Compare March 19, 2024 10:37
Copy link
Member

@malhussan malhussan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome addition! I think it is worth writing a text in README mentioning we support this as well

modules/meshcloud-metering-service-principal/module.tf Outdated Show resolved Hide resolved
@henryde henryde force-pushed the feature/workload-identity-federation branch from 316c0da to 6a36992 Compare March 19, 2024 10:59
Allow metering and replicator service principals to use workload
identity federation instead of passwords.
@henryde henryde force-pushed the feature/workload-identity-federation branch from 6a36992 to 15645d1 Compare March 19, 2024 12:49
@henryde henryde added this pull request to the merge queue Mar 20, 2024
Merged via the queue into main with commit c958b66 Mar 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants