Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for mergeBufferGeometries failure when loading Collada files with inconsistent attributes #139

Closed
wants to merge 5 commits into from
Closed

Workaround for mergeBufferGeometries failure when loading Collada files with inconsistent attributes #139

wants to merge 5 commits into from

Commits on Dec 14, 2022

  1. Add handling of broken DAE objects with materials 

    The ColladaLoader fails for some DAE files that contain textures for
some geometries but not for others. This workaround (currently
deactivated) would remove all textures if this were to be the case. This
prevents "non-loading" of geometries and falls back to loading them
without textures
    @wxmerkt
    wxmerkt committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    2b565c0 View commit details
    Browse the repository at this point in the history

  2. Add try catch to DAE and STL loader to catch and output parsing excep… 

    …tions
    @wxmerkt
    wxmerkt committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    309f958 View commit details
    Browse the repository at this point in the history

  3. Add Uint8Array decoding, fixes loading of binary STLs from meshcat-py… 

    …thon

Unclear why we need to specialise this type since the switch from
msgpack-lite to msgpack - but without it the geometries do not get
decoded.
    @wxmerkt
    wxmerkt committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    d3e0fee View commit details
    Browse the repository at this point in the history

  4. Update main.min.js

    @wxmerkt
    wxmerkt committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    bd9738f View commit details
    Browse the repository at this point in the history

  5. Update main.min.js

    @wxmerkt
    wxmerkt committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    956b73f View commit details
    Browse the repository at this point in the history