Use GOCACHE in .circleci #561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krhubert
force-pushed
the
feature/gocache
branch
from
8e5a141
to
c3fbfad
Compare
krhubert
force-pushed
the
feature/gocache
branch
from
c3fbfad
to
c814f9c
Compare
antho1404
reviewed
Nov 1, 2018
antho1404
previously approved these changes
Nov 2, 2018
|
I have removed coverprofile because we don't use it now and go test cache doesn't work with it. It has open issues about it:
So we need to remove coverprofile to speed up the tests or wait for go 1.12 (or maybe even 1.13, because I don't see this issue on 1.12 milestone) |
|
As decided, we keep coverprofile and waits to go team to fix the issues. |
NicolasMahe
changed the title
|
This pull request has been mentioned on MESG Community. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.