Skip to content

Commit

Permalink
dockerfile: pin node version
Browse files Browse the repository at this point in the history
node:22 has been released yesterday and it is broken. With node 22,
after `npm install`, the directory ./node_modules/.bin is empty, and you
should call `npm install` twice.

Instead, pinning to a working version of the node image works.
  • Loading branch information
brmzkw committed Jul 19, 2024
1 parent 8999d59 commit d1d4e45
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
#
# Javascript builder for static files
#
FROM node AS node-builder
FROM node:20 AS node-builder

WORKDIR /app
COPY package.json package-lock.json /app/

RUN npm install

#
Expand Down Expand Up @@ -88,4 +89,4 @@ CMD python manage.py makemigrations && python manage.py migrate && \
--limit-post=24000000 \
--http-manage-expect \
--ignore-sigpipe --ignore-write-errors --disable-write-exception \
--cron='0 -1 -1 -1 -1 poetry run python /app/manage.py runcrons'
--cron='0 -1 -1 -1 -1 poetry run python /app/manage.py runcrons'

0 comments on commit d1d4e45

Please sign in to comment.