Update executable version suffixes for ruby 3.0-3.3 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Locke <[email protected]>
Signed-off-by: Kevin Locke <[email protected]>
As with gem and ruby, complete version-suffixed commands as well. The bundle and bundler commands have had a version suffix on Debian systems since at least Ruby 2.7, as seen in the [ruby2.7 file list], and is still used, as shown in the [ruby3.3 file list]. [ruby2.7 file list]: https://packages.debian.org/bullseye/amd64/ruby2.7/filelist [ruby3.3 file list]: https://packages.debian.org/sid/amd64/ruby3.3/filelist Signed-off-by: Kevin Locke <[email protected]>
As with gem and ruby, complete version-suffixed commands as well. The rake command has had a version suffix on Debian systems since at least Ruby 2.7, as seen in the [ruby2.7 file list], and is still used, as shown in the [ruby3.3 file list]. [ruby2.7 file list]: https://packages.debian.org/bullseye/amd64/ruby2.7/filelist [ruby3.3 file list]: https://packages.debian.org/sid/amd64/ruby3.3/filelist Signed-off-by: Kevin Locke <[email protected]>
|
Thanks! I had completely forgotten about versioned names. I was a bit surprised with the inclusion of Bundler and Rake, but I see that Ubuntu indeed has versioned variants of them (example), so I'm accepting it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completions are currently only installed for commands with version suffixes between 1.8 and 2.7. This PR adds completion for
gemandrubywith version suffixes 3.0, 3.1, 3.2, and 3.3. It also adds completion forbundleandrakecommands with version suffixes, which were not previously supported (or incompletely supported). If you'd prefer a separate PR for these additions, please let me know.Thanks for considering,
Kevin
Previous update: #11