-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: V2. Change StateDB to class based architecture. #6250
Refactor: V2. Change StateDB to class based architecture. #6250
Conversation
🦋 Changeset detectedLatest commit: 88abf46 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6250 +/- ##
==========================================
- Coverage 4.47% 4.47% -0.01%
==========================================
Files 384 384
Lines 54180 54233 +53
Branches 623 623
==========================================
Hits 2425 2425
- Misses 51755 51808 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Co-authored-by: Sidharth Vinod <[email protected]>
@omkarht this PR should be merged soon, you can fix the direction bug now. |
📑 Summary
diagramObject.db
is called.rootDoc
, but the DB was not updated. Now, the DB is set using theextract
function whensetRootDoc
is called.Previous PR: #6185
Revert PR: #6218
📏 Design Decisions
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.