-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warning: add observer as runtime dependency #367
base: master
Are you sure you want to change the base?
Conversation
Thank you, but even with this addition the gem doesn't work with Ruby 3.4 (and tests error out). Please add an available ruby 3.4 version to |
Alright, I'll update my PR when I'll have some time. Out of curiosity, which source did you use for compatibility matrix between Rails and Ruby version ? I found this one https://www.fastruby.io/blog/ruby/rails/versions/compatibility-table.html and I see that Rails 5.2 is not compatible with Ruby 2.7, yet you only excluded Ruby 3.0 in the |
I checked whether it errored out or failed any of merit's tests, disallowing only combinations that I couldn't work out. |
Travis CI was offline for this project for long @pbourdet, I just converted the project to GitHub Actions: 08e65bd See matrix of tests in the last run: https://github.com/merit-gem/merit/actions/runs/9822341907 You may add ruby 3.4, and rails 7.2 beta if you please. cc @fedesapuppo who was following this issue too. |
Hello @tute, Great, nice work! Sorry I got busy and didn't have much time for this PR. I quickly added ruby 3.4 in the matrix just to see. The build did not start though 🤔. Do you have to start it manually ? Edit : yes it looks like it's waiting for a maintainer approval 😄 |
Right, just ran it. Left a comment |
Hello @tute, I updated my PR, if you can try to re-run the build |
Hello,
Fix of the following warning :
observer
won't be part of the default gems with ruby 3.4