attempt to fix issue #354 and #355 #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
due to some copy-and-pasto, `DynDefinedSpec._build_odxlinks()` unconditionally called itself and the `oid` parameter was missing from the fallback code for DTC decoding. (Be aware that the latter points towards an incomplete dataset.) Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: David Helwig <[email protected]>
|
@svnmic: can you test if this fixes your issues? (I don't have any datasets which use |
kayoub5
approved these changes
Oct 28, 2024
|
okay, I suppose this fixes two clear bugs, so let's merge it even if it might not be sufficient to get around all of @svnmic's issues... |
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to some copy-and-pasto,
DynDefinedSpec._build_odxlinks()unconditionally called itself and theoidparameter was missing from the fallback code for DTC decoding. (Be aware that the latter points towards an incomplete dataset.)Andreas Lauser <[email protected]>, on behalf of MBition GmbH.
Provider Information