Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: publish repository #1

Closed
wants to merge 3 commits into from
Closed

chore: publish repository #1

wants to merge 3 commits into from

Conversation

ParaZera
Copy link
Collaborator

No description provided.

andlaus and others added 3 commits April 8, 2024 14:14
So far, this only contains the required scaffolding files. The actual
software will be contributed later.

Signed-off-by: Andreas Lauser <[email protected]>
Signed-off-by: Christian Hackenbeck <[email protected]>
Signed-off-by: Alexander Walz <[email protected]>
Signed-off-by: Rose Sturm <[email protected]>
Signed-off-by: Christina Ibrom <[email protected]>
@andlaus
Copy link
Member

andlaus commented Apr 15, 2024

WTF: I renamed README.md to README.rst in the main branch so that this PR is compatible, and github closed the PR on me when I force pushed. fun! (can you re-do the PR please?)

@andlaus
Copy link
Member

andlaus commented Apr 15, 2024

BTW: as far as I understood this, the second commit needs to be removed because for copyright reasons, the text of the Apache license must not be modified. The section which you changed is just instructing people to add a "// Copyright (c) 2023-2024 by Frickly Systems GmbH" comment at the top of source code files. That said, personally I prefer to not add such legal statements because

  • In German law, these comments do not change anything because the copyright for the code is automatically with the author regardless of what a comment at the top of the file says or who pushed the file (I believe)
  • They are annoying to maintain/keep up to date
  • The information conveyed therein can be more accurately obtained from the git logs (note that this not a fool proof method because the holder of the copyright is not necessarily related to the person who committed to git. in practice, this is the same person in more than about 98% of all cases, though.)
  • They might scare off external contributors because they might convey some false sense of "ownership" of the code in question.

That said, I'm not dogmatic about this issue, so if you prefer to keep these copyright comments, I'm perfectly fine with it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants