chore: refactor to stop using the cache #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaudjester
force-pushed
the
no-cache-anymore
branch
from
20bfd82 to
f450dde
Compare
uriii3
reviewed
Jul 15, 2024
| subset_request = subset_request_from_file(request_file) | ||
| subset_request.from_file(request_file) | ||
| if not subset_request.dataset_id: | ||
| raise ValueError("Please provide a dataset id for a subset request.") | ||
| if motu_api_request: | ||
| motu_api_subset_request = convert_motu_api_request_to_structure( | ||
| motu_api_request | ||
| ) | ||
| subset_request.update(motu_api_subset_request.__dict__) | ||
| request_update_dict = { |
There was a problem hiding this comment.
are we sure that you can delete the update of the id? nothing weird with python variables?
There was a problem hiding this comment.
I don't think so but better be on the side of caution
There was a problem hiding this comment.
I checked and it seems to work with the obvious cases
renaudjester
commented
Jul 15, 2024
| raise syntax_error | ||
| else: | ||
| dataset_id = subset_request.dataset_id | ||
| raise SyntaxError("Must specify 'dataset_id' option") |
uriii3
approved these changes
Jul 16, 2024
renaudjester
force-pushed
the
no-cache-anymore
branch
from
785d7df to
0f1a7d4
Compare
uriii3
pushed a commit
that referenced
this pull request
Jul 31, 2024
Not using any cache anymore Always get the data on the fly
uriii3
pushed a commit
that referenced
this pull request
Jul 31, 2024
Not using any cache anymore Always get the data on the fly
uriii3
pushed a commit
that referenced
this pull request
Jul 31, 2024
Not using any cache anymore Always get the data on the fly
uriii3
pushed a commit
that referenced
this pull request
Jul 31, 2024
Not using any cache anymore Always get the data on the fly
uriii3
pushed a commit
that referenced
this pull request
Jul 31, 2024
Not using any cache anymore Always get the data on the fly
uriii3
pushed a commit
that referenced
this pull request
Jul 31, 2024
Not using any cache anymore Always get the data on the fly
renaudjester
added a commit
that referenced
this pull request
Aug 20, 2024
Not using any cache anymore Always get the data on the fly
renaudjester
added a commit
that referenced
this pull request
Aug 20, 2024
Not using any cache anymore Always get the data on the fly
renaudjester
added a commit
that referenced
this pull request
Aug 20, 2024
Not using any cache anymore Always get the data on the fly
renaudjester
added a commit
that referenced
this pull request
Aug 20, 2024
Not using any cache anymore Always get the data on the fly
renaudjester
added a commit
that referenced
this pull request
Aug 29, 2024
Not using any cache anymore Always get the data on the fly
renaudjester
added a commit
that referenced
this pull request
Aug 29, 2024
Not using any cache anymore Always get the data on the fly
renaudjester
added a commit
that referenced
this pull request
Aug 29, 2024
Not using any cache anymore Always get the data on the fly
renaudjester
added a commit
that referenced
this pull request
Aug 29, 2024
Not using any cache anymore Always get the data on the fly fix: use pendulum to parse dates chore: use pendulum accross the repo fix: to pendulum datetime from boto3 fix: microsecond problem with boto3
renaudjester
added a commit
that referenced
this pull request
Aug 29, 2024
Not using any cache anymore Always get the data on the fly fix: use pendulum to parse dates chore: use pendulum accross the repo fix: to pendulum datetime from boto3 fix: microsecond problem with boto3
uriii3
pushed a commit
that referenced
this pull request
Sep 3, 2024
Not using any cache anymore Always get the data on the fly
uriii3
pushed a commit
that referenced
this pull request
Sep 5, 2024
Not using any cache anymore Always get the data on the fly
uriii3
pushed a commit
that referenced
this pull request
Sep 17, 2024
Not using any cache anymore Always get the data on the fly
renaudjester
added a commit
that referenced
this pull request
Oct 28, 2024
Not using any cache anymore Always get the data on the fly
renaudjester
added a commit
that referenced
this pull request
Oct 28, 2024
Not using any cache anymore Always get the data on the fly
renaudjester
added a commit
that referenced
this pull request
Oct 28, 2024
Not using any cache anymore Always get the data on the fly
renaudjester
added a commit
that referenced
this pull request
Oct 28, 2024
Not using any cache anymore Always get the data on the fly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: CMT-2 and stop using the cache